Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
neilkakkar
reviewed
Feb 6, 2023
|
|
||
| You can [check the current list in the source code for the app.](https://github.com/PostHog/posthog-plugin-geoip) | ||
|
|
||
| ## A working example |
Contributor
There was a problem hiding this comment.
.. since you're at it, can we also add removing a $set person property?
So we can avoid this in the future: PostHog/posthog-plugin-geoip#19
Basically, $set.$geoip_city_name removes the city name from $set properties.
Member
Author
There was a problem hiding this comment.
I think I've got that 🙈
neilkakkar
approved these changes
Feb 6, 2023
neilkakkar
reviewed
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
see thread in slack here: https://posthogusers.slack.com/archives/C01GLBKHKQT/p1673883644411219
Checklist